Skip to content

(maint) Update very old Beaker version in Gemfile #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 19, 2019
Merged

(maint) Update very old Beaker version in Gemfile #201

merged 2 commits into from
Jun 19, 2019

Conversation

glennsarti
Copy link
Contributor

Currently beaker is pinned at version 2.x which causes issues on Windows with
modern Ruby. Beaker 2.x pulls in VERY old versions of nokogiri which cannot
be compiled on Windows. This commit updates the Beaker version pin to version
3.x as this has been out for over a year, and will allow developers on Windows
to at least do a bundle install. Later commits may update this to the latest
beaker version (4.x)

@glennsarti
Copy link
Contributor Author

Note the very old nokogiri version

Installing json 1.8.6 with native extensions
Fetching nokogiri 1.5.11
Installing nokogiri 1.5.11 with native extensions
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

current directory:
C:/Source/puppet-strings/.bundle/windows/ruby/2.5.0/gems/nokogiri-1.5.11/ext/nokogiri
C:/tools/ruby2.5.1-2x64/bin/ruby.exe -r ./siteconf20190618-29788-cv9l2d.rb
extconf.rb
checking for libxml/parser.h... no
-----
libxml2 is missing.  please visit
http://nokogiri.org/tutorials/installing_nokogiri.html for help with installing
dependencies.
-----
*** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of necessary
libraries and/or headers.  Check the mkmf.log file for more details.  You may
need configuration options.

...


An error occurred while installing nokogiri (1.5.11), and Bundler cannot
continue.
Make sure that `gem install nokogiri -v '1.5.11' --source
'https://rubygems.org/'` succeeds before bundling.

In Gemfile:
  beaker-rspec was resolved to 2.0.0, which depends on
    beaker was resolved to 1.16.0, which depends on
      aws-sdk was resolved to 1.42.0, which depends on
        nokogiri

@glennsarti @scotje
(maint) Update very old Beaker version in Gemfile
5829820 
Currently beaker is pinned at version 2.x which causes issues on Windows with
modern Ruby.  Beaker 2.x pulls in VERY old versions of nokogiri which cannot
be compiled on Windows.  This commit updates the Beaker version pin to version
3.x as this has been out for over a year, and will allow developers on Windows
to at least do a bundle install.  Later commits may update this to the latest
beaker version (4.x)
@scotje scotje force-pushed the maint-fix-gemfile branch from 1121a77 to 5829820 Compare June 19, 2019 18:03
@scotje
Copy link
Contributor

scotje commented Jun 19, 2019

Rebased and updated beaker pin to ~> 3.37

@scotje
(MAINT) Bump travis puppet4 cell to Ruby 2.1.9
da1bfe2 
The README specifies a minimum Ruby version of 2.1.9, and we only
relaxed the gemspec requirement to 2.1.0 in PDOC-259 to support some
puppet_agent module testing. Skipping 2.1.0 for testing allows us to
bump our dev-only dependency on Beaker to a reasonably modern range.
Since there is no runtime dependency on Beaker, this shouldn't break
downstream users on Ruby 2.1.0.
@scotje scotje merged commit 8b9e267 into puppetlabs:master Jun 19, 2019
@glennsarti
Copy link
Contributor Author

glennsarti commented Jun 20, 2019 •
edited
Loading

@scotje The ruby version was specifically set at 2.1.0 due to hhttps://github.com/puppetlabs/puppet-strings/commit/2dfc8073b36f38690475a9cc6e004bf065e90cdc

@glennsarti glennsarti deleted the maint-fix-gemfile branch July 17, 2019 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glennsarti @scotje